Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add test fixtures #356

Merged
merged 2 commits into from
Jul 17, 2023
Merged

fix: add test fixtures #356

merged 2 commits into from
Jul 17, 2023

Conversation

Mustaballer
Copy link
Collaborator

@Mustaballer Mustaballer commented Jul 6, 2023

What kind of change does this PR introduce?

Add test fixtures for future tests that need recordings

  • use temporary db with seeded recording for testing

Summary

Addresses #314

Checklist

  • My code follows the style guidelines of OpenAdapt
  • I have performed a self-review of my code
  • If applicable, I have added tests to prove my fix is functional/effective
  • I have linted my code locally prior to submission
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
  • New and existing unit tests pass locally with my changes

How can your code be run and tested?

Other information

@Mustaballer
Copy link
Collaborator Author

Ready for review :)

@abrichr abrichr merged commit 0ee5397 into OpenAdaptAI:main Jul 17, 2023
R-ohit-B-isht pushed a commit to R-ohit-B-isht/OpenAdapt that referenced this pull request Jun 21, 2024
* fix: add test fixtures

* revert test_summary.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants